fix(dashboards): Render unfurl chart with dual Y axes for multi-aggregate widgets#115411
Merged
DominikB2014 merged 4 commits intoMay 13, 2026
Merged
Conversation
…gate widgets Multi-aggregate widgets (e.g. `count(span.duration)` + `avg(span.duration)`) previously rendered with a single Y axis in Slack unfurl charts. The chartcuterie config now reuses the dashboard's axis partitioning so unfurls match the UI. Extracts the partitioning into `assignPlottablesToYAxes` so the dashboard widget visualization and the chartcuterie unfurl chart share one implementation.
github-actions
Bot
added
the
Scope: Frontend
Contributor
📊 Type Coverage Diff
🔍 4 new type safety issues introducedNon-null assertions (
Type assertions (
This is informational only and does not block the PR. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit d0f1978. Configure here.
A `null` `dataUnit` is a legitimate "unitless" value. Previously the truthiness check on `units[0]` dropped a consensus `null` through to the fallback unit lookup (e.g. `duration` → `millisecond`), diverging from the dashboard's original behavior.
Matches the partitioning, comments, and Sentry error logging from the in-line implementation that used to live in `TimeSeriesWidgetVisualization`. The visualization now delegates yAxisPosition resolution to `assignPlottablesToYAxes` instead of duplicating the if/else block, and the chartcuterie call site renames `realizedPlottables` to `plottables`.
narsaynorath
approved these changes
May 12, 2026
DominikB2014
deleted the
dominikbuszowiecki/fix/dashboards-unfurl-dual-yaxis
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Multi-aggregate dashboard widgets (e.g.
count(span.duration)+avg(span.duration)) previously rendered with a single Y axis in Slack unfurl charts, even when the dashboard UI showed two. The chartcuterie config now reuses the dashboard's axis partitioning so unfurls render the same way as the UI —counton the left,durationon the right.Shared partitioner
assignPlottablesToYAxeslives next to the rest of the time-series widget code and is consumed by bothTimeSeriesWidgetVisualizationandchartcuterie/timeseries.tsx. It encapsulates the same rules used in the UI: one type → left only; two types → split; three+ types → first on left, rest on right (or all on left when the first type is the fallback).Code generated with Claude